#17008: makemessages too eager to cleanup, makes it hard to debug errors
-------------------------------------+-------------------------------------
     Reporter:  airstrike            |                    Owner:  airstrike
         Type:  New feature          |                   Status:  new
    Component:  Core (Management     |                  Version:  1.3
  commands)                          |               Resolution:
     Severity:  Normal               |             Triage Stage:  Accepted
     Keywords:  makemessages .pot    |      Needs documentation:  0
  .po gettext xgettext translation   |  Patch needs improvement:  1
  debug                              |                    UI/UX:  0
    Has patch:  1                    |
  Needs tests:  1                    |
Easy pickings:  1                    |
-------------------------------------+-------------------------------------
Changes (by julien):

 * needs_better_patch:  0 => 1


Comment:

 I've updated the patch to current trunk and did a little pep8-cleanup.

 It'd be nice to add more comprehensive tests. The main purpose of the
 `--keep-pot` option is for debugging in case the `makemessages` command
 (or more precisely the underlying calls to xgettext, msgmerge and msguniq)
 crashes, yet the patch currently only tests when everything works.

 I'm not entirely sure how to write tests for this yet. Maybe that could be
 done by monkey-patching the `_popen()` function.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/17008#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Reply via email to