#17467: compare id of Site object with SITE_ID before updating (in 
create_test_db)
-------------------------------------+-------------------------------------
     Reporter:  kallous@…            |                    Owner:  nobody
         Type:  Bug                  |                   Status:  closed
    Component:  Database layer       |                  Version:  1.3
  (models, ORM)                      |               Resolution:  fixed
     Severity:  Release blocker      |             Triage Stage:  Design
     Keywords:                       |  decision needed
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by aaugustin):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Sorry, I was confused in my previous comments. Like I said, there's a lot
 of history :)

 The code you're suggesting to patch was removed at r16868 in trunk and at
 r16869 in 1.3.X. Django now ensures that the id of the default site object
 is 1 without updating the primary key; it creates the object directly with
 the proper id. If I understand correctly, that should fix your problem.

 I just edited that code, here's what it looks like now
 
[https://code.djangoproject.com/browser/django/trunk/django/contrib/sites/management.py?rev=17343
 on trunk] and
 
[https://code.djangoproject.com/browser/django/branches/releases/1.3.X/django/contrib/sites/management.py?rev=17343
 on 1.3.X].

 Thanks for the report, and feel free to reopen this ticket if the issue
 persists! (I don't have access to a MSSQL database to validate the current
 code.)

-- 
Ticket URL: <https://code.djangoproject.com/ticket/17467#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Reply via email to