#17025: sql/where.py WhereNode refactoring
-------------------------------------+-------------------------------------
Reporter: akaariai | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: 1.3
Component: Database layer | Resolution:
(models, ORM) | Triage Stage: Design
Severity: Normal | decision needed
Keywords: orm cleanup | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 1
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by snyderra@…):
I applied the patch from ticket
[https://code.djangoproject.com/ticket/16759 16759] to the appropriate
revision. did a diff to the 1.3.1 download and merged the changes into the
1.3.1. so the 30% speed increase is during a bulk data insert that is also
intensive in lookups for processing of the data. the speed increase is
purely due to the reduction of time spent in deepcopy. that method alone
was using ~40% of the compute time according to cProfile. after the patch
it was reduced to 12%, so almost 30% I will add the patch to 16759 for
people that want to use it with the 1.3.1. now the bottle neck is database
access as I would expect and not deepcopy.
Replying to [comment:15 akaariai]:
> I will see if I have time to update the patch to apply to trunk version.
Until that time, I think the patch applies to roughly r16950 (found out by
clicking "3 months" link after the patch, and picking some revision around
the time the patch was posted).
>
> I also set "patch needs improvement" as clearly the patch isn't
applicable as is. The patch needs more work than just making it apply
cleanly to trunk (more comments, cleanup and better aggregate handling).
>
> BTW what was your test that resulted in 30% speedup?
--
Ticket URL: <https://code.djangoproject.com/ticket/17025#comment:16>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
