#6499: Close open file descriptors on compression
-------------------------------------+-------------------------------------
Reporter: Bastian Kleineidam | Owner: nobody
<calvin@…> | Status: closed
Type: | Version: SVN
Cleanup/optimization | Resolution: invalid
Component: Core (Other) | Triage Stage: Accepted
Severity: Normal | Needs documentation: 0
Keywords: | Patch needs improvement: 0
Has patch: 1 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by aaugustin):
* status: new => closed
* resolution: => invalid
Comment:
Closing the `GzipFile` is useful because it flushes its buffers. Closing
the `StringIO` isn't necessary; it will be garbage collected eventually.
I fail to see the point of the patch: there's no fd involved in this code,
and even if `zbuf` were a fd, the patch wouldn't close it (see
http://hg.python.org/cpython/file/91cbac92a665/Lib/gzip.py#l359).
--
Ticket URL: <https://code.djangoproject.com/ticket/6499#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
