#17867: validate_email fails with IDN domains
-------------------------------------+-------------------------------------
     Reporter:  Pierre               |                    Owner:  nobody
  <pierre.matri@…>                   |                   Status:  new
         Type:  Bug                  |                  Version:
    Component:  Forms                |  1.4-beta-1
     Severity:  Normal               |               Resolution:
     Keywords:  idn                  |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by claudep):

 * needs_docs:   => 0
 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


Comment:

 The fix is correct. Seems we forgot to fix the domain regex for email
 validator when we fixed it for URLs (r15502).

 About tests, I don't like seeing half of email validation tests in
 browser:django/trunk/tests/regressiontests/forms/tests/fields.py and
 another half in browser:django/trunk/tests/modeltests/validators/tests.py.
 I'd rather have them all in modeltests. That could be taken care of by the
 committer.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/17867#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Reply via email to