#17856: Pass "obj" parameter to get_inline_instances
-------------------------------------+-------------------------------------
Reporter: ybon | Owner: nobody
Type: Uncategorized | Status: new
Component: contrib.admin | Version:
Severity: Release blocker | 1.4-beta-1
Keywords: | Resolution:
Has patch: 1 | Triage Stage: Design
Needs tests: 1 | decision needed
Easy pickings: 0 | Needs documentation: 0
| Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by aaugustin):
* severity: Normal => Release blocker
* stage: Unreviewed => Design decision needed
Comment:
First, `get_inline_instances` wasn't introduced as a new API, but to fix a
permission-checking bug on inlines. See r16934. Viewing it a a hook for
admin customization is interesting :)
Currently, it isn't documented, which makes it an internal API. And we
don't commit to keeping backwards compatibility for internal APIs. If you
use or override them and they change in a later version of Django, you're
on your own -- and in this case it will be trivial to fix. That means we
could make that change after 1.4.
Alternatively, if we decide it's a public of "semi-public" API, and try
not to break backwards compatibility, we need the API to be correct and
consistent with surrounding code before it's set in stone. If we're
choosing this path, this bug is a release blocker.
I'm marking this as a release blocker because we must decide between (a)
accepting to change the API after 1.4 (b) fix it now. If we choose (a)
then it's a normal ticket, if we choose (b) then it's a release blocker.
Given this situation, the patch being as harmless as they come, and the
convincing (IMO) arguments of Yohan on the mailing list, I'm seriously
tempted to make the change.
--
Ticket URL: <https://code.djangoproject.com/ticket/17856#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
