#14497: ModelAdmin.readonly_fields isn't graceful with filefields.
-------------------------------------+-------------------------------------
Reporter: Keryn Knight | Owner:
<keryn@…> | paulcollins
Type: New feature | Status: new
Component: contrib.admin | Version: 1.2
Severity: Normal | Resolution:
Keywords: feature admin | Triage Stage: Accepted
readonly filefield | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 1
Needs tests: 0 | UI/UX: 1
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by julien):
* needs_better_patch: 0 => 1
Comment:
Thank you, Paul. I realized the test was failing for me because of the
hardcoded "media/" in the url path. Using the string variable
`STORAGE_URL` fixes that (see patch above).
I've also noticed that the same display logic is used on the changelist
when a file field is in `list_display`. It'd be great to write an extra
test to cover that test. Other than that, the patch looks great!
--
Ticket URL: <https://code.djangoproject.com/ticket/14497#comment:16>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
