#18083: Multi-table inheritance subclasses proxy deletion is broken
-------------------------------------+-------------------------------------
     Reporter:  charettes            |                    Owner:  charettes
         Type:  Bug                  |                   Status:  new
    Component:  Database layer       |                  Version:  1.4
  (models, ORM)                      |               Resolution:
     Severity:  Normal               |             Triage Stage:  Accepted
     Keywords:  model proxy multi-   |      Needs documentation:  0
  table inheritance                  |  Patch needs improvement:  0
    Has patch:  1                    |                    UI/UX:  0
  Needs tests:  0                    |
Easy pickings:  0                    |
-------------------------------------+-------------------------------------
Changes (by charettes):

 * has_patch:  0 => 1
 * stage:  Unreviewed => Accepted


Comment:

 Attached a patch that fixes the issue but change the way `pre_delete` and
 `post_delete` signals are sent.

 Before patch only the `ConcreteModelSubclassProxy`'s signals we're sent
 which was definitely buggy.

 When the patch is applied `ConcreteModelSubclassProxy`'s and then
 `ConcreteModel`'s signals are sent which is still buggy but better IMHO.

 In this particular case I beleive signals for the three classes should be
 triggered in this order: `ConcreteModelSubclassProxy` then
 `ConcreteModelSubclass` and finally `ConcreteModel`. But that’s another
 story, as suggested by @carljm I'll open a new ticket that depends on this
 one and attempt to fix the signal issue there.

 I'm also exceptionally marking as ''Accepted'' my own bug because I had
 agreement it's a valid bug on IRC.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/18083#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Reply via email to