#9245: Using choices in a mode field forces use of TypedChoiceField in a form
field
------------------------+------------------------------------
Reporter: Tarken | Owner: badri
Type: Bug | Status: reopened
Component: Forms | Version: 1.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
------------------------+------------------------------------
Changes (by julien):
* needs_docs: 0 => 1
* needs_better_patch: 1 => 0
Comment:
Thank you for your work and sorry for the late review.
In the revised patch attached, I've moved the logic to a new, separate
method called `choices_formfield()`. This complicates the API slightly,
but at least it removes the necessity for all subclasses of `Field` to
modify their logic based on `self.choices`.
I'll seek some feedback. If this approach is approved then some
documentation will be needed.
--
Ticket URL: <https://code.djangoproject.com/ticket/9245#comment:14>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
