#18700: `set_language` view documentation uses hard-coded URL
--------------------------------------+------------------------------------
     Reporter:  DrMeers               |                    Owner:  DrMeers
         Type:  Cleanup/optimization  |                   Status:  new
    Component:  Documentation         |                  Version:  1.4
     Severity:  Normal                |               Resolution:
     Keywords:                        |             Triage Stage:  Accepted
    Has patch:  1                     |      Needs documentation:  0
  Needs tests:  0                     |  Patch needs improvement:  0
Easy pickings:  0                     |                    UI/UX:  0
--------------------------------------+------------------------------------

Comment (by DrMeers):

 > What about using 'set_language' as view name?

 Yes, I agree. `setlang` irked me, but I thought I should match it. I'd
 like to change the URLconf to use `/set-language/` too, but backwards-
 compatibility might pose problems (which is exactly why we *don't* use
 hardcoded URLs, especially in official documentation!)


 > I think that we should also use the url template tag in the form action
 url

 That link seems to be the one that I've already patched?

-- 
Ticket URL: <https://code.djangoproject.com/ticket/18700#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to