#18748: Remove dupe-avoidance logic from the ORM
-------------------------------------+-------------------------------------
Reporter: akaariai | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: master
Component: Database layer | Resolution:
(models, ORM) | Triage Stage: Accepted
Severity: Normal | Needs documentation: 0
Keywords: | Patch needs improvement: 0
Has patch: 1 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by akaariai):
* stage: Ready for checkin => Accepted
Comment:
Quick testing and seems this isn't the case. I added a join counter (how
many times ' JOIN ' is found in the executed SQL) and ran queries,
select_related, select_related_regress, many_to_many, aggregation_regress
and select_related tests. All produce exactly as many joins.
Another reason to think this will not reduce joins is that the dedupe is
used to mark joins to _exclude_ from reuse, so the dedupe would cause more
joins to appear if anything. Although, the code is complex and it is
sometimes hard to see what exactly is happening...
I will still downgrade this from RFC, this probably is a bit too large
change to just push in...
--
Ticket URL: <https://code.djangoproject.com/ticket/18748#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
