Branch: refs/heads/master
Home: https://github.com/django/django
Commit: 4e9a74b81df1c7aaea2f90a3a4911920e134b275
https://github.com/django/django/commit/4e9a74b81df1c7aaea2f90a3a4911920e134b275
Author: Carl Meyer <[email protected]>
Date: 2012-09-19 (Wed, 19 Sep 2012)
Changed paths:
M django/db/models/query.py
M docs/releases/1.5.txt
M tests/modeltests/get_or_create/tests.py
Log Message:
-----------
Revert "Fixed #16865 -- Made get_or_create use read database for initial get
query."
Thanks to Jeremy Dunck for pointing out the problem with this change. If in a
single transaction, the master deletes a record and then get_or_creates a
similar record, under the new behavior the get_or_create would find the record
in the slave db and fail to re-create it, leaving the record nonexistent, which
violates the contract of get_or_create that the record should always exist
afterwards. We need to do everything against the master here in order to ensure
correctness.
This reverts commit 901af865505310a70dd02ea5b3becbf45819b652.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit https://groups.google.com/groups/opt_out.
