#19099: Broken link email sent on redirect by i18n_patterns
------------------------------------------------+------------------------
Reporter: aaugustin | Owner: nobody
Type: Bug | Status: new
Component: Internationalization | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
With the following settings:
{{{
MIDDLEWARE_CLASSES = {
# ...,
'django.middleware.locale.LocaleMiddleware',
'django.middleware.common.CommonMiddleware',
# ...,
}
SEND_BROKEN_LINKS_EMAIL = True
}}}
when a redirect to an i18n'd URL occurs, a broken link email is sent.
I'm attaching a failing test case.
This may be the expected behavior, but it's hard to diagnose. I started
receiving broken link emails for '/', with various referrers and UAs. But
going to that URL worked and didn't send an email, because there's no
referrer when you go straight to the URL.
The solution might be documenting that `CommonMiddleware` must come before
`LocaleMiddleware`. The commit logs say that they used to be in that
order, but that we swapped them because `APPEND_SLASH` didn't work (I
haven't re-verified this yet). And then I started receiving the broken
link emails.
--
Ticket URL: <https://code.djangoproject.com/ticket/19099>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit https://groups.google.com/groups/opt_out.
