#19189: FormWizard done method can't revisit forms
-----------------------------------+--------------------------------------
Reporter: kenth | Owner: nobody
Type: New feature | Status: closed
Component: contrib.formtools | Version: master
Severity: Normal | Resolution: needsinfo
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+--------------------------------------
Changes (by russellm):
* status: new => closed
* resolution: => needsinfo
Comment:
The intended contract for done() is that at point of entry, all the forms
are valid. If there is validation to be performed, it should be performed
in the clean methods for the previous forms.
To follow through your example -- if one of the things you need to do for
a valid form is to check the credit card, why isn't this being done as
part of the cleaning for the form that took the credit card details? By
your own admission - the right response if the card is declined is to re-
show the credit card page, so why should the already existing clean method
handle this?
Closing needsinfo; feel free to reopen if you can explain why this *can't*
(not just "I don't want to") be handled as part of the form's clean
method.
--
Ticket URL: <https://code.djangoproject.com/ticket/19189#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit https://groups.google.com/groups/opt_out.
