#19083: postgresql_psycopg2 backend - rename get_version to get_pg_version
-------------------------------------+-------------------------------------
     Reporter:  toms.baugis@…        |                    Owner:  nobody
         Type:  Bug                  |                   Status:  closed
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |               Resolution:  invalid
     Severity:  Normal               |             Triage Stage:
     Keywords:                       |  Unreviewed
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by toms.baugis@…):

 raven is the backend for sentry that makes it possible to follow traces in
 production in an easy manner. one thing that is does is trying to pull out
 versions from all the modules

 a sample search:
 
http://code.ohloh.net/search?s=%22get_version%22&browser=Default&pp=0&fl=Python&fd=mdef&mp=1&ml=0&me=1&md=1&ff=1&filterChecked=true

 Shows that there are quite a few cases where the __version__ is missing
 and much less often function by name get_version is expecting any vars.

 Filing a bug against all these cases so that raven could rely only on
 __version__ is unfeasible, but changing the function name in django
 posgtres backend to get_db_version would be trivial and also an arguably
 better function name.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/19083#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to