#19327: Admin doesn't handle double login attempts -------------------------------------+------------------------------------- Reporter: KJ | Owner: KJ Type: Bug | Status: new Component: contrib.admin | Version: master Severity: Normal | Resolution: Keywords: | Triage Stage: Accepted sensitive_post_parameters, login | Needs documentation: 0 Has patch: 1 | Patch needs improvement: 1 Needs tests: 1 | UI/UX: 0 Easy pickings: 1 | -------------------------------------+------------------------------------- Changes (by russellm):
* needs_better_patch: 0 => 1 * needs_tests: 0 => 1 Comment: Problem definitely exists, but: * The patch needs tests. This is something the test client can test really easily, so there's not reason not to. * There are more reliable checks for "is logged in" than checking the contents of POST -- you should be able to check request.user.is_authenticated to evaluate if the user is logged in. -- Ticket URL: <https://code.djangoproject.com/ticket/19327#comment:3> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To post to this group, send email to django-updates@googlegroups.com. To unsubscribe from this group, send email to django-updates+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.