#19184: Remove EmptyQuerySet
-------------------------------------+-------------------------------------
Reporter: akaariai | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: 1.4
Component: Database layer | Resolution:
(models, ORM) | Triage Stage: Ready for
Severity: Normal | checkin
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by akaariai):
* needs_better_patch: 1 => 0
* stage: Design decision needed => Ready for checkin
Comment:
OK, patch updated (available from
https://github.com/akaariai/django/compare/rm_emptyqs).
The EmptyQuerySet isn't instantiable any more, but that is more like an
added feature than backwards compatibility problem. However the
EmptyQuerySet still exists as a way to check if a queryset is from .none()
call.
So, we don't have a backwards compatibility problem, and I think the
performance regression caused by this change falls into category "if you
don't have to be correct it is easy to be fast".
I will leave this ticket open for review & comments for some time, then
commit.
--
Ticket URL: <https://code.djangoproject.com/ticket/19184#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit https://groups.google.com/groups/opt_out.
