#19447: Intword and intabr expansion and intword_internal api exposure
----------------------------------+------------------------------------
Reporter: eire1130 | Owner: eire1130
Type: New feature | Status: new
Component: contrib.humanize | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
----------------------------------+------------------------------------
Changes (by russellm):
* needs_better_patch: 0 => 1
* stage: Unreviewed => Accepted
Comment:
It took me a while to work out what you were trying to do here. Suggestion
for the future -- when proposing a feature, don't bury the lede. The
suggestion here is to add two features:
* an intabr template tag that returns 1.2M rather than 1.2 million, and
* a precision option for the intword/abr flag.
Changes to internal API and implementation are largely irrelevant to the
end effect. They might be worth mentioning as a way of validating why your
patch implements a feature a particular way.
Accepting the broad concept. However, regarding implementation:
* I don't accept the need for intword_internal. What's the use case?
* The implementation seems excessively complex. What you're doing is a
very simple lookup of prefixes based on the number of decimal places. Why
does this require an interable class instance, other than to prove that
you know how to use Python iterators?
* I'm not wild about intabr as a name for the new template tag. If we
were going to abbreviate at all, I'd use abbr, not abr; but I'd prefer a
better name altogether. Suggestions welcome, but inthuman and intlarge are
two to start with.
--
Ticket URL: <https://code.djangoproject.com/ticket/19447#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit https://groups.google.com/groups/opt_out.
