#12914: Use yaml faster C implementation when available --------------------------------------+------------------------------------ Reporter: Beuc | Owner: nobody Type: Cleanup/optimization | Status: new Component: Core (Serialization) | Version: master Severity: Normal | Resolution: Keywords: | Triage Stage: Accepted Has patch: 1 | Needs documentation: 0 Needs tests: 0 | Patch needs improvement: 1 Easy pickings: 0 | UI/UX: 0 --------------------------------------+------------------------------------ Changes (by akaariai):
* status: closed => new * resolution: fixed => Comment: The commit is causing some failures in timezone tests (there might be other failures, too, haven't ran the full suite): {{{ (py3_venv)akaariai@akaariai-UX31E:~/Programming/django/tests$ ./runtests.py --settings=test_sqlite timezones Creating test database for alias 'default'... Creating test database for alias 'other'... .......sssssss....s..............s......s...............FFFFFF................. ====================================================================== FAIL: test_aware_datetime_in_local_timezone (modeltests.timezones.tests.SerializationTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/akaariai/Programming/django/tests/modeltests/timezones/tests.py", line 625, in test_aware_datetime_in_local_timezone self.assert_yaml_contains_datetime(data, "2011-09-01 13:20:30+03:00") File "/home/akaariai/Programming/django/tests/modeltests/timezones/tests.py", line 507, in assert_yaml_contains_datetime self.assertIn("- fields: {dt: !!timestamp '%s'}" % dt, yaml) AssertionError: "- fields: {dt: !!timestamp '2011-09-01 13:20:30+03:00'}" not found in "- fields: {dt: ! '2011-09-01 13:20:30+03:00'}\n model: timezones.event\n pk: null\n" <SNIP similar errors...> ---------------------------------------------------------------------- Ran 79 tests in 0.332s FAILED (failures=6, skipped=10) }}} The failures happen only if pyyaml is installed, and only on Python 3. Here is freeze of the py3_venv: {{{ Markdown==2.2.1 PyYAML==3.10 cx-Oracle==5.1.2 distribute==0.6.30 djangobench==0.9 docutils==0.10 flake8==1.7.0 ipdb==0.7 ipython==0.13.1 psycopg2==2.4.6 pytz==2012j textile==2.1.5 wsgiref==0.1.2 }}} -- Ticket URL: <https://code.djangoproject.com/ticket/12914#comment:9> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To post to this group, send email to django-updates@googlegroups.com. To unsubscribe from this group, send email to django-updates+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.