On Fri, Oct 5, 2012 at 12:51 AM, Julian Cerruti <[email protected]> wrote: > Apparently the current implementation of URLField rejects Web Sockets URLs > such as ws://my.server.com/ > > This seems to be due to the implementation of the underlying URLValidator, > which has a regex to search for ftp or http based URLs only. > > Is there any chance the URLValidator regexp can be updated to include ws as > a valid protocol qualifier too?
Certainly possible. I might have some question as to whether Web Sockets URLs should be allowed in the general case. The current field validates for HTTP and FTP because they're the things you'd expect a user to put into the field for a "Homepage", for example; a web socket URL is an entirely valid URL, but it's not something you'd expect for a homepage. A flag/option may be called for. > Also, more generally, what is the recommended procedure for proposing > changes (and accompanying code) such as this? Open a ticket, provide a patch (with tests). Wait for someone to review said patch. If the wait becomes too long, try reviewing someone else's patch and get some karma in return. Yours, Russ Magee %-) -- You received this message because you are subscribed to the Google Groups "Django users" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/django-users?hl=en.
