Ok, thanks. On Monday, 13 July 2015 16:14:29 UTC+1, Avraham Serour wrote: > > Personally I don't see obvious errors, but it is hard to tell with only > this small snippet. > > If it works what are you worried about? Performance? If you are having > performance problems you can try caching the query > > On Mon, Jul 13, 2015 at 6:08 PM, Joss Ingram <[email protected] > <javascript:>> wrote: > >> Ok, thanks fair enough. >> >> my Question then is : >> >> Is the query above bad? >> >> On Mon, Jul 13, 2015 at 4:00 PM, Avraham Serour <[email protected] >> <javascript:>> wrote: >> >>> You told a story but didn't ask a question >>> >>> On Mon, Jul 13, 2015 at 5:54 PM, Joss Ingram <[email protected] >>> <javascript:>> wrote: >>> >>>> I'm not getting much joy with my question, is there too little info? >>>> >>>> On Friday, 10 July 2015 15:31:50 UTC+1, Joss Ingram wrote: >>>>> >>>>> Hi, >>>>> >>>>> In my models I have an event index page type, which can have child >>>>> event pages, each event page can be tagged (using taggit), and I want to >>>>> produce a list of distinct tags used in the events that belong to that >>>>> event index on the index itself. I'm using the Django CMS Wagtail, but I >>>>> guess this is really a Django ORM query question. I''ve got some code as >>>>> part of my model which is working but I don't think it's the most >>>>> efficient >>>>> way of doing this. Still trying unlearn doing things with SQL and learn >>>>> how >>>>> the same thing should be done in Django. >>>>> >>>>> My code as part of the event index class is >>>>> >>>>> @property >>>>> def event_tag_list(self): >>>>> child_events = EventPage.objects.live().descendant_of(self) >>>>> return >>>>> Tag.objects.filter(mysite_eventpagetag_items__isnull=False).filter(mysite_eventpagetag_items__content_object_id=child_events).order_by('slug').distinct('slug') >>>>> >>>>> Any feedback would be appreciated. >>>>> >>>>> Thanks >>>>> >>>>> Joss >>>>> >>>>> >>>>> >>>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "Django users" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected] <javascript:>. >>>> To post to this group, send email to [email protected] >>>> <javascript:>. >>>> Visit this group at http://groups.google.com/group/django-users. >>>> To view this discussion on the web visit >>>> https://groups.google.com/d/msgid/django-users/61cf7c97-ae40-4c71-a094-ff1d819a7ce5%40googlegroups.com >>>> >>>> <https://groups.google.com/d/msgid/django-users/61cf7c97-ae40-4c71-a094-ff1d819a7ce5%40googlegroups.com?utm_medium=email&utm_source=footer> >>>> . >>>> >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> >>> -- >>> You received this message because you are subscribed to a topic in the >>> Google Groups "Django users" group. >>> To unsubscribe from this topic, visit >>> https://groups.google.com/d/topic/django-users/qB8W-I3jJWg/unsubscribe. >>> To unsubscribe from this group and all its topics, send an email to >>> [email protected] <javascript:>. >>> To post to this group, send email to [email protected] >>> <javascript:>. >>> Visit this group at http://groups.google.com/group/django-users. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/django-users/CAFWa6t%2B1dpT%3D3oYG%2BqRopr9vWWXwY573%2BM%2BzkuT8ijxwYXo%2Brg%40mail.gmail.com >>> >>> <https://groups.google.com/d/msgid/django-users/CAFWa6t%2B1dpT%3D3oYG%2BqRopr9vWWXwY573%2BM%2BzkuT8ijxwYXo%2Brg%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Django users" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <javascript:>. >> To post to this group, send email to [email protected] >> <javascript:>. >> Visit this group at http://groups.google.com/group/django-users. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/django-users/CAA%3DX%3DqeGwJ1OwOQw0C4jAr7nzWJUsKGeryAQ%3DgoicuJbCWr5HQ%40mail.gmail.com >> >> <https://groups.google.com/d/msgid/django-users/CAA%3DX%3DqeGwJ1OwOQw0C4jAr7nzWJUsKGeryAQ%3DgoicuJbCWr5HQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> >> For more options, visit https://groups.google.com/d/optout. >> > >
-- You received this message because you are subscribed to the Google Groups "Django users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/django-users. To view this discussion on the web visit https://groups.google.com/d/msgid/django-users/a1e9a02f-b6bd-4f03-a2e5-808bbfbea80c%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
