> Does this mean I should globally replace "str(" with "|six.text_type(" in a
> 2/3 codebase?|
I don't think so; afaiu this must be done for the return value of __str__(), not
everywhere.Antonis Christofides http://djangodeployment.com On 2017-04-12 02:33, Mike Dewhirst wrote: > On 12/04/2017 2:52 AM, Tim Graham wrote: >> As documented >> <https://docs.djangoproject.com/en/1.11/ref/utils/#django.utils.encoding.python_2_unicode_compatible> >> you must return /text/ and not /bytes/ from |__str__()| when using >> |@python_2_unicode_compatible|. That means |six.text_type(self.a)| rather >> than |str(self.a)| (which returns bytes on Python 2). > Tim > > Does this mean I should globally replace "str(" with "|six.text_type(" in a > 2/3 codebase?| > > ??? > > Cheers > > Mike > >> >> On Tuesday, April 11, 2017 at 11:18:02 AM UTC-4, Christophe Pettus wrote: >> >> I've run into the issue described in the code below, where (as far >> as I can tell) a natural use of __str__ in Python 2.7 results in a >> Unicode error. I'm not quite sure how to write this code to work >> properly on both Python 2 and Python 3; what am I missing? >> >> (Note this issue happens on Python 2.7 regardless of the presence >> of the @python_2_unicode_compatible decorator.) >> >> Models: >> >> from django.db import models >> from django.utils.encoding import python_2_unicode_compatible >> >> @python_2_unicode_compatible >> class A(models.Model): >> c = models.CharField(max_length=20) >> >> def __str__(self): >> return self.c >> >> @python_2_unicode_compatible >> class B(models.Model): >> a = models.ForeignKey(A) >> >> def __str__(self): >> return str(self.a) >> >> >> Failure example: >> >> >>> from test.models import A, B >> >>> a = A(c=u'répairer') >> >>> a.save() >> >>> a.id <http://a.id> >> 1 >> >>> a1 = A.objects.get(id=1) >> >>> a1 >> <A: répairer> >> >>> b = B(a_id=1) >> >>> b.save() >> >>> b.id <http://b.id> >> 1 >> >>> b1 = B.objects.get(id=1) >> >>> b1 >> <B: [Bad Unicode data]> >> >>> print b1 >> Traceback (most recent call last): >> File "<console>", line 1, in <module> >> File >> >> "/Users/xof/Documents/Dev/environments/peep/lib/python2.7/site-packages/django/utils/six.py", >> line 842, in <lambda> >> klass.__str__ = lambda self: self.__unicode__().encode('utf-8') >> UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in >> position 1: ordinal not in range(128) >> >> -- -- Christophe Pettus >> [email protected] <javascript:> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Django users" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] >> <mailto:[email protected]>. >> To post to this group, send email to [email protected] >> <mailto:[email protected]>. >> Visit this group at https://groups.google.com/group/django-users. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/django-users/96a2e023-bf4b-4584-ae36-30e9d48c8927%40googlegroups.com >> <https://groups.google.com/d/msgid/django-users/96a2e023-bf4b-4584-ae36-30e9d48c8927%40googlegroups.com?utm_medium=email&utm_source=footer>. >> >> For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Django users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/django-users. To view this discussion on the web visit https://groups.google.com/d/msgid/django-users/0b5fdb54-a011-d71c-3b22-ef542a419cdd%40djangodeployment.com. For more options, visit https://groups.google.com/d/optout.
