ooh, nice! missed that part. Did you consider having that pull from a CDN rather than locally? Reason being, any updates to said polyfills will require you to deploy an update. Whereas if you have a template tag to pull from a CDN, you can have your users specify the version if necessary and pull the latest by default. Would be one less thing you have to worry about maintaining.
https://cdnjs.com/libraries/event-source-polyfill https://www.jsdelivr.com/package/npm/reconnecting-eventsource Also, what's the reason for having json2 in the static files? https://github.com/douglascrockford/JSON-js even states On current browsers, this file does nothing, preferring the built-in JSON object. There is no reason to use this file unless fate compels you to support IE8, which is something that no one should ever have to do again. > > Other than that, the lib looks pretty good to me. </thumbs-up> On Wednesday, June 13, 2018 at 9:20:44 PM UTC-4, Justin Karneges wrote: > > Thanks Jason! The library comes with Yaffle's polyfill for IE/Edge > support, that can be included with a template tag. > > https://github.com/fanout/django-eventstream#receiving-in-the-browser > > On Wed, Jun 13, 2018 at 5:20 PM, Jason <[email protected] <javascript:>> > wrote: > >> Nice library! good work :-) >> >> I would suggest you update your readme to reflect that SSE is not >> supported by any MS browser (IE or Edge) as shown by >> https://caniuse.com/#feat=eventsource. >> >> >> On Wednesday, June 13, 2018 at 7:34:21 PM UTC-4, Justin Karneges wrote: >>> >>> Hi folks, >>> >>> I'm pleased to announce an SSE library for Django: >>> https://github.com/fanout/django-eventstream >>> >>> The library makes pushing data from the server really easy. It uses >>> Channels under the hood, although you don't have to write any async code. >>> Simply declare endpoints in routing.py and call send_event() from anywhere. >>> >>> I hope others find it useful. >>> >>> Justin >>> >> -- You received this message because you are subscribed to the Google Groups "Django users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/django-users. To view this discussion on the web visit https://groups.google.com/d/msgid/django-users/dfe6f4ad-006d-422f-8911-1cbab60f038e%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
