The below 'if' should probably be:

if (pstate == NULL || pstate->ps_state < 1)

- Chris


On Fri, Dec 21, 2007 at 09:01:37PM +0000, Werner Wiethege wrote:
> Testing against DKIM 2.4.1 fails but succeeds against 2.4.0.
> 
> Looks like the first step in dkim_policy, where the validity of
> the signature is checked, is never executed.
> 
> The parameter pstate was added to dkim_policy in 2.4.1, it's set
> to NULL when mlfi_eom calls dkim_policy and doesn't change until
> it's tested to see whether a valid signature exists:
> 
>    /*
>    **  1. If a valid Originator Signature exists, the message is
>    **  not Suspicious, and the algorithm terminates.
>    */
> 
>    if (pstate != NULL && pstate->ps_state < 1)
>    {
> 
> With dkim=strict and no "t" tag it falls through to step 10
> and the message is considered suspicious.
> 
> ww
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2005.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> dkim-milter-discuss mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/dkim-milter-discuss
> 
> !DSPAM:476c29ce676951449714380!

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
dkim-milter-discuss mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dkim-milter-discuss

Reply via email to