Re: Apache XML-RPC libs fail to quotify < and & in

[Daniel Rall]

Adam Megacz <[EMAIL PROTECTED]> writes:

> The Apache XML-RPC libraries fail to transform '<' into '&lt;' and '&'
> into '&amp;' when they occur in a Hashtable key (<name/> element).
> 
> This can be fixed by removing this line (XmlRpc.java:756)
> 
>     write(nextkey);
> 
> And replacing it with this line:
> 
>     chardata(nextkey);

Committed to CVS HEAD.  Messages like this should go to the
[EMAIL PROTECTED] list.  Thanks!

- Dan


Index: XmlWriter.java
===================================================================
RCS file: /home/cvs/xml-rpc/src/java/org/apache/xmlrpc/XmlWriter.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -u -r1.1 -r1.2
--- XmlWriter.java      7 Aug 2002 17:44:36 -0000       1.1
+++ XmlWriter.java      8 Aug 2002 21:31:50 -0000       1.2
@@ -226,13 +226,13 @@
             Hashtable struct = (Hashtable) obj;
             for (Enumeration e = struct.keys(); e.hasMoreElements(); )
             {
-                String nextkey = (String) e.nextElement();
-                Object nextval = struct.get(nextkey);
+                String key = (String) e.nextElement();
+                Object value = struct.get(key);
                 startElement("member");
                 startElement("name");
-                write(nextkey);
+                chardata(key);
                 endElement("name");
-                writeObject(nextval);
+                writeObject(value);
                 endElement("member");
             }
             endElement("struct");