Eric Biggers <[email protected]> wrote: > > +static noinline_for_stack int > +shash_finup_mb_fallback(struct shash_desc *desc, const u8 * const data[], > + unsigned int len, u8 * const outs[], > + unsigned int num_msgs) > +{
I haven't got around to my version but just to recap, I'm not going to plumb this into shash at all. My mb interface will be ahash only. At the same time, I will add a new vaddr interface to the top side of ahash so that vaddr users do not have to create an SG list unnecessarily. The API will handle the mechanics of plumbing this into drivers that require SG lists. Whether all vaddrs are allowed or only a subset (kmalloc + vmalloc) is yet to be decided. Of course it wouldn't be hard to extend (kmalloc + vmalloc) to all addresses by simply allocating a bounce buffer + copying. Cheers, -- Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
