On Sat, 2024-07-13 at 02:04 -0400, Benjamin Marzinski wrote:
> Pull the code that gets the new path state out into a helper function
> named check_path_state(), in preparation for splittig check_path()
> into two functions.
>
> Signed-off-by: Benjamin Marzinski <[email protected]>
> ---
> multipathd/main.c | 64 ++++++++++++++++++++++++++++-----------------
> --
> 1 file changed, 38 insertions(+), 26 deletions(-)
>
> -
> + newstate = check_path_state(pp);
> if (newstate == PATH_WILD || newstate == PATH_UNCHECKED) {
> - condlog(2, "%s: unusable path (%s) - checker
> failed",
> - pp->dev, checker_state_name(newstate));
> - LOG_MSG(2, pp);
> - conf = get_multipath_config();
> - pthread_cleanup_push(put_multipath_config, conf);
> - pathinfo(pp, conf, 0);
> - pthread_cleanup_pop(1);
> return 1;
Nit: Remove braces here?
> } else if ((newstate != PATH_UP && newstate != PATH_GHOST &&
> newstate != PATH_PENDING) && (pp->state ==
> PATH_DELAYED)) {
Thanks,
Martin
