Replace the swp function pointer in the min_heap_callbacks of
test_min_heap with NULL, allowing direct usage of the default builtin
swap implementation. This modification simplifies the code and improves
performance by removing unnecessary function indirection.

Signed-off-by: Kuan-Wei Chiu <visitor...@gmail.com>
---
Tested with test_min_heap module.

 lib/test_min_heap.c | 16 ++++------------
 1 file changed, 4 insertions(+), 12 deletions(-)

diff --git a/lib/test_min_heap.c b/lib/test_min_heap.c
index 64c877e73b64..e6fbb798558b 100644
--- a/lib/test_min_heap.c
+++ b/lib/test_min_heap.c
@@ -23,14 +23,6 @@ static __init bool greater_than(const void *lhs, const void 
*rhs, void __always_
        return *(int *)lhs > *(int *)rhs;
 }
 
-static __init void swap_ints(void *lhs, void *rhs, void __always_unused *args)
-{
-       int temp = *(int *)lhs;
-
-       *(int *)lhs = *(int *)rhs;
-       *(int *)rhs = temp;
-}
-
 static __init int pop_verify_heap(bool min_heap,
                                struct min_heap_test *heap,
                                const struct min_heap_callbacks *funcs)
@@ -72,7 +64,7 @@ static __init int test_heapify_all(bool min_heap)
        };
        struct min_heap_callbacks funcs = {
                .less = min_heap ? less_than : greater_than,
-               .swp = swap_ints,
+               .swp = NULL,
        };
        int i, err;
 
@@ -104,7 +96,7 @@ static __init int test_heap_push(bool min_heap)
        };
        struct min_heap_callbacks funcs = {
                .less = min_heap ? less_than : greater_than,
-               .swp = swap_ints,
+               .swp = NULL,
        };
        int i, temp, err;
 
@@ -136,7 +128,7 @@ static __init int test_heap_pop_push(bool min_heap)
        };
        struct min_heap_callbacks funcs = {
                .less = min_heap ? less_than : greater_than,
-               .swp = swap_ints,
+               .swp = NULL,
        };
        int i, temp, err;
 
@@ -175,7 +167,7 @@ static __init int test_heap_del(bool min_heap)
        heap.nr = ARRAY_SIZE(values);
        struct min_heap_callbacks funcs = {
                .less = min_heap ? less_than : greater_than,
-               .swp = swap_ints,
+               .swp = NULL,
        };
        int i, err;
 
-- 
2.34.1


Reply via email to