On Wed, 2024-12-04 at 22:56 -0500, Benjamin Marzinski wrote:
> reload_map() was calling select_action() with force_reload set. Since
> mpp will always be a member of vecs->mpvec when reload_map() is
> called,
> when cmpp and cmpp_by_name are looked up in select_action(), they
> will
> just point to mpp. This means that none of the early checks related
> to
> cmpp in select_action() will do anything, and the action will always
> end up being ACT_RELOAD. So we can just set ACT_RELOAD in
> reload_map()
> and skip the work.
> 
> Additionally, calling select_action() with force_reload set will set
> force_udev_reload. This isn't necessary for any of the reload_map()
> callers, and will just cause udev to do extra work. I did set
> force_udev_reload in cli_reload(), so that it works like calling
> "multipath -r", which does force udev to rescan the device.
> 
> Signed-off-by: Benjamin Marzinski <bmarz...@redhat.com>

Reviewed-by: Martin Wilck <mwi...@suse.com>


Reply via email to