On 23.04.25 08:10, Hannes Reinecke wrote:
> On 4/22/25 16:26, Christoph Hellwig wrote:
>> Remove the q argument from blk_rq_map_kern and the internal helpers
>> called by it as the queue can trivially be derived from the request.
>>
>> Signed-off-by: Christoph Hellwig <h...@lst.de>
>> ---
>>    block/blk-map.c            | 24 ++++++++++--------------
>>    drivers/block/pktcdvd.c    |  2 +-
>>    drivers/block/ublk_drv.c   |  3 +--
>>    drivers/block/virtio_blk.c |  4 ++--
>>    drivers/nvme/host/core.c   |  2 +-
>>    drivers/scsi/scsi_ioctl.c  |  2 +-
>>    drivers/scsi/scsi_lib.c    |  3 +--
>>    include/linux/blk-mq.h     |  4 ++--
>>    8 files changed, 19 insertions(+), 25 deletions(-)
>>
> Good cleanup. I always wondered why we need to have it.

Because we used to call 'bio_add_pc_page()' in e.g. bio_map_kern()' 
which took a request_queue. But that got changed in 6aeb4f8364806 
("block: remove bio_add_pc_page") to a simple 'bio_add_page()'.

So much for the archeology,
Reviewed-by: Johannes Thumshirn <johannes.thumsh...@wdc.com>

Reply via email to