Re: [PATCH] vdo: omit need_resched() before cond_resched()

[Matthew Sakai]

On 7/14/25 12:27 PM, Mikulas Patocka wrote:

There's no need to call need_resched() because cond_resched() will do
nothing if need_resched() returns false.

Signed-off-by: Mikulas Patocka <mpato...@redhat.com>

Reviewed-by: Matthew Sakai <msa...@redhat.com>

---
  drivers/md/dm-vdo/funnel-workqueue.c |    3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

Index: linux-2.6/drivers/md/dm-vdo/funnel-workqueue.c
===================================================================
--- linux-2.6.orig/drivers/md/dm-vdo/funnel-workqueue.c 2024-03-30 
20:07:03.000000000 +0100
+++ linux-2.6/drivers/md/dm-vdo/funnel-workqueue.c      2025-07-14 
18:17:59.000000000 +0200
@@ -252,8 +252,7 @@ static void service_work_queue(struct si
                 * This speeds up some performance tests; that "other work" 
might include other VDO
                 * threads.
                 */
-               if (need_resched())
-                       cond_resched();
+               cond_resched();
        }

run_finish_hook(queue);