On Tue, Jul 22, 2025 at 01:28:33AM +0800, Funda Wang wrote:
> When building multipath-tools with cmocka 1.1.8. it produces following
> error when make test:
>
> In file included from test-log.c:6:
> test-log.c: In function '__wrap_dlog':
> test-log.c:24:20: error: 'uintptr_t' undeclared (first use in this function)
> 24 | expected = mock_ptr_type(char *);
> | ^~~~~~~~~~~~~
> test-log.c:10:1: note: 'uintptr_t' is defined in header '<stdint.h>'; did
> you forget to '#include <stdint.h>'?
> 9 | #include "debug.h"
> +++ |+#include <stdint.h>
> 10 |
> test-log.c:24:20: note: each undeclared identifier is reported only once
> for each function it appears in
> 24 | expected = mock_ptr_type(char *);
> | ^~~~~~~~~~~~~
> test-log.c:24:20: error: expected ')' before '_mock'
> 24 | expected = mock_ptr_type(char *);
> | ^~~~~~~~~~~~~
> test-log.c:24:20: note: to match this '('
> 24 | expected = mock_ptr_type(char *);
> | ^~~~~~~~~~~~~
> make[1]: *** [Makefile:74: test-log.o] Error 1
> rm parser.o.wrap dmevents.o.wrap hwtable.o.wrap uevent.o.wrap
> blacklist.o.wrap util.o.wrap
> make[1]: Leaving directory
> '/home/lkp/rpmbuild/BUILD/multipath-tools-0.9.5/tests'
> make: *** [Makefile:121: test] Error 2
> error: Bad exit status from /var/tmp/rpm-tmp.7qc9Bd (%check)
>
> The attached patch solved this issue. Thanks.
>
> GitHub pull request: https://github.com/opensvc/multipath-tools/pull/117
Looks good, but for future reference, it's easier to apply if the patch
is inline ("git format-patch" and "git send-email" will make sure it's
in the proper form. We use the same email workflow as the linux kernel,
so you can look at linux kernel patch submission instructions for
how to use git to submit patches). But thanks for the fix.
Reviewed-by: Benjamin Marzinski <bmarz...@redhat.com>
