Hi Bart, On Thu, 2025-10-09 at 16:29 -0700, Bart Van Assche wrote: > On 10/9/25 2:57 AM, Martin Wilck wrote: > > In general, I'm wondering whether we need a more generic solution > > to > > this problem. Therefore I've added linux-block to cc. > > > > The way I see it, if a device has queued IO without any means to > > perform the IO, it can't be frozen. We'd either need to fail all > > queued > > IO in this case, or refuse attempts to freeze the queue. > > If a device has queued I/O and the I/O can't make progress then it > isn't > necessary to call blk_mq_freeze_queue(), isn't it?
Good point. Even if the queue limits were changed while the IO was in the queue, they'd be re-checked in blk_insert_cloned_request(). That might cause IO failures, but if you modify queue limits while IO is in flight, that's part of the risk, I suppose. > See also "[PATCH 0/3] > Fix a deadlock related to modifying queue attributes" > ( > https://lore.kernel.org/linux-block/[email protected] > /). > > BTW, that patch series is not upstream. I apply it manually every > time > before I run blktests. Will you make another attempt to get it merged? Martin
