Re: [PATCH] dm-bufio: align write boundary on bdev_logical_block_size

[Mikulas Patocka]

On Wed, 19 Nov 2025, Christoph Hellwig wrote:

> On Tue, Nov 18, 2025 at 06:45:55PM +0100, Mikulas Patocka wrote:
> > I changed the patch below, so that it aligns write bios on 
> > max3(DM_BUFIO_WRITE_ALIGN, bdev_logical_block_size(b->c->bdev), 
> > bdev_physical_block_size(b->c->bdev)); - so that if physical block size is 
> > greater than logical block size, the writes are aligned so that the device 
> > doesn't do read-modify-write.
> 
> That doesn't make any sense whatsoever.  The physical block size must
> be >= logical block size, and the block enforces that.

OK, so I changed it to max(DM_BUFIO_WRITE_ALIGN, 
bdev_physical_block_size(b->c->bdev))

Mikulas