On Mon, Nov 24, 2025 at 07:49:35PM -0700, Keith Busch wrote: > On Mon, Nov 24, 2025 at 06:12:30PM +0100, Christoph Hellwig wrote: > > On Mon, Nov 24, 2025 at 09:09:01AM -0800, Keith Busch wrote: > > > From: Keith Busch <[email protected]> > > > > > > The dma_alignment becomes 511 anyway if the caller doesn't explicitly > > > set it. But setting this default prevents the stacked device from > > > requesting a lower value even if it can handle lower alignments. > > > > Given how much trouble we had with drivers doing software processing > > and unaligned buffers I'd feel more comfortable keeping this default > > limitation. Drivers that want to relax it can still trivially do > > that right after calling blk_set_stacking_limits. > > That should have the same result, but it's totally fine with me if you > prefer the caller overwrite the default instead.
I think it's much safer if we require the opt-in.
