On Mon, 2026-01-12 at 17:16 +0100, Xose Vazquez Perez wrote:
> Cc: Martin Wilck <[email protected]>
> Cc: Benjamin Marzinski <[email protected]>
> Cc: Christophe Varoqui <[email protected]>
> Cc: DM_DEVEL-ML <[email protected]>
> Signed-off-by: Xose Vazquez Perez <[email protected]>
> ---
>  libmpathcmd/libmpathcmd.version         | 2 +-
>  libmpathpersist/libmpathpersist.version | 2 +-
>  libmpathutil/libmpathutil.version       | 2 +-
>  libmpathutil/strbuf.c                   | 2 +-
>  libmpathutil/strbuf.h                   | 2 +-
>  libmultipath/libmultipath.version       | 2 +-
>  multipathd/multipathc.c                 | 2 +-
>  tests/cli.c                             | 3 +--
>  tests/devt.c                            | 3 +--
>  tests/mapinfo.c                         | 2 +-
>  tests/mpathvalid.c                      | 3 +--
>  tests/strbuf.c                          | 2 +-
>  tests/sysfs.c                           | 2 +-
>  tests/vpd.c                             | 2 +-
>  14 files changed, 14 insertions(+), 17 deletions(-)
> 
> diff --git a/libmpathcmd/libmpathcmd.version
> b/libmpathcmd/libmpathcmd.version
> index 81bdb2b7..e672755a 100644
> --- a/libmpathcmd/libmpathcmd.version
> +++ b/libmpathcmd/libmpathcmd.version
> @@ -1,6 +1,6 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later

It turns out that the linker doesn't appreciate C++-style comments in
linker scripts. I'll fix that, but next time please compile-test your
patches.

I'm not sure if the license tag really needs to be in the
first line of every file. I only found the recommendation to
put it "near the top". Anyway,

Reviewed-by: Martin Wilck <[email protected]>

[ I thought I'd sent a response to this patch already, but I can't find
it any more. Sorry if you get this multiple times. ]

Reply via email to