dm_verity_fec::corrected seems to have been intended to count the number
of corrected blocks.  However, it actually counted the number of calls
to fec_decode_bufs() that corrected at least one error.  That's not the
same thing.  For example, in low-memory situations correcting a single
block can require many calls to fec_decode_bufs().

Fix it to count corrected blocks instead.

Fixes: ae97648e14f7 ("dm verity fec: Expose corrected block count via status")
Cc: Shubhankar Mishra <[email protected]>
Cc: [email protected]
Signed-off-by: Eric Biggers <[email protected]>
---
 drivers/md/dm-verity-fec.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/md/dm-verity-fec.c b/drivers/md/dm-verity-fec.c
index 9f06bd66bae31..d4a9367a2fee6 100644
--- a/drivers/md/dm-verity-fec.c
+++ b/drivers/md/dm-verity-fec.c
@@ -161,15 +161,13 @@ static int fec_decode_bufs(struct dm_verity *v, struct 
dm_verity_io *io,
        dm_bufio_release(buf);
 
        if (r < 0 && neras)
                DMERR_LIMIT("%s: FEC %llu: failed to correct: %d",
                            v->data_dev->name, (unsigned long long)rsb, r);
-       else if (r > 0) {
+       else if (r > 0)
                DMWARN_LIMIT("%s: FEC %llu: corrected %d errors",
                             v->data_dev->name, (unsigned long long)rsb, r);
-               atomic64_inc(&v->fec->corrected);
-       }
 
        return r;
 }
 
 /*
@@ -437,10 +435,11 @@ int verity_fec_decode(struct dm_verity *v, struct 
dm_verity_io *io,
                if (r < 0)
                        goto done;
        }
 
        memcpy(dest, fio->output, 1 << v->data_dev_block_bits);
+       atomic64_inc(&v->fec->corrected);
 
 done:
        fio->level--;
        return r;
 }
-- 
2.52.0


Reply via email to