On 21/02/26 6:49 AM, SeongJae Park wrote:
> On Thu, 12 Feb 2026 17:33:30 +0100 (CET) Mikulas Patocka
> <[email protected]> wrote:
>
>> The commit 07003531e03c8 ("mm/vmalloc: warn on invalid vmalloc gfp
>> flags") breaks the device mapper VDO target. The VDO target calls vmalloc
>> with __GFP_RETRY_MAYFAIL and this flag is not in the mask of allowed
>> flags.
>>
>> There is no reason why vmalloc couldn't support __GFP_RETRY_MAYFAIL, so
>> let's add this flag to GFP_VMALLOC_SUPPORTED.
>>
>> Signed-off-by: Mikulas Patocka <[email protected]>
>> Reported-by: Zdenek Kabelac <[email protected]>
>> Fixes: 07003531e03c ("mm/vmalloc: warn on invalid vmalloc gfp flags")
>> Cc: [email protected] # v6.19
>
> Acked-by: SeongJae Park <[email protected]>
>
>>
>> ---
>> mm/vmalloc.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> Index: linux-2.6/mm/vmalloc.c
>> ===================================================================
>> --- linux-2.6.orig/mm/vmalloc.c
>> +++ linux-2.6/mm/vmalloc.c
>> @@ -3928,6 +3928,7 @@ fail:
>> */
>> #define GFP_VMALLOC_SUPPORTED (GFP_KERNEL | GFP_ATOMIC | GFP_NOWAIT |\
>> __GFP_NOFAIL | __GFP_ZERO | __GFP_NORETRY |\
>> + __GFP_RETRY_MAYFAIL |\
>> GFP_NOFS | GFP_NOIO | GFP_KERNEL_ACCOUNT |\
>> GFP_USER | __GFP_NOLOCKDEP)
>
> By the way, I think this list might better to be alphabetically sorted in
Agreed.
> future. Obviously just a trivial and random thought that never required for
> this patch.
Reviewed-by: Anshuman Khandual <[email protected]>
