Re: [PATCH 12/18] libmultipath: convert RDAC checker to async checker

[Benjamin Marzinski]

On Tue, May 05, 2026 at 05:43:26PM +0200, Martin Wilck wrote:
> Make the RDAC checker use the async checker framework.
> 
> Signed-off-by: Martin Wilck <mwi...@suse.com>
> ---
>  libmultipath/checkers/rdac.c | 30 ++++++++++--------------------
>  1 file changed, 10 insertions(+), 20 deletions(-)
> 
> diff --git a/libmultipath/checkers/rdac.c b/libmultipath/checkers/rdac.c
> index 87b8872..a477fb5 100644
> --- a/libmultipath/checkers/rdac.c
> +++ b/libmultipath/checkers/rdac.c
> @@ -1,8 +1,6 @@
>  /*
>   * Copyright (c) 2005 Christophe Varoqui
>   */
> -#include <stdio.h>
> -#include <stdlib.h>
>  #include <string.h>
>  #include <sys/types.h>
>  #include <sys/stat.h>
> @@ -15,6 +13,7 @@
>  #include "debug.h"
>  
>  #include "sg_include.h"
> +#include "async_checker.h"
>  
>  #define INQUIRY_CMDLEN               6
>  #define INQUIRY_CMD          0x12
> @@ -55,11 +54,7 @@ struct control_mode_page {
>       unsigned char dontcare1[6];
>  };
>  
> -struct rdac_checker_context {
> -     void * dummy;
> -};
> -
> -int libcheck_init (struct checker * c)
> +int libcheck_init(struct checker *c)

This function doesn't get called anymore. Do we not need to set the
TAS bit for some reason?

-Ben

>  {
>       unsigned char cmd[MODE_SEN_SEL_CMDLEN];
>       unsigned char sense_b[SENSE_BUFF_LEN];