On Mon, Oct 26, 2026 at 04:55:28PM -0700, Eric Biggers wrote: > On Sun, Oct 25, 2026 at 03:10:12AM +0300, Jarkko Sakkinen wrote: > > +/** > > + * keyring_is_empty - Check whether a keyring contains any links > > + * @keyring: The keyring to check. > > + */ > > "contains any links" => "contains no links"? Or even just "is empty". > Otherwise it sounds backwards. > > Note that another "is the keyring empty" check just showed up in > mainline in kernel/bpf/keys.c. So a new version of this patch will be > needed to update that one too. > > Otherwise this patch looks good.
I'll fix that up. Related, bpf_keyring_lookup() also needs to be addressed now that I have it in my tree. > > - Eric Br, Jarkko
