Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] dm persistent data: Fixes trailer cites wrong commit for node_copy() --
commit f0758e03fa9ea11bfbf4ab38d82540be653f4f13 Author: Mikulas Patocka <[email protected]> > dm persistent data: test return value of node_copy > > There were 3 places where the return value of node_copy was not tested. > > Signed-off-by: Mikulas Patocka <[email protected]> > Assisted-by: Claude:claude-opus-5 > Cc: [email protected] > Fixes: 3241b1d3e0aa ("dm: add persistent data library") [Severity: Low] In commit 3241b1d3e0aa ("dm: add persistent data library"), node_copy() returned void and used BUG_ON() for error checks. Commit c671ffa55d8b ("dm btree remove: change a bunch of BUG_ON() calls to proper errors") converted node_copy() to return an error code and left the three call sites in __rebalance2() and delete_center_node() unchecked. Should the Fixes tag be: Fixes: c671ffa55d8b ("dm btree remove: change a bunch of BUG_ON() calls to proper errors") -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
