On 07/08/2016 06:28 PM, Xose Vazquez Perez wrote:
> OPTFLAGS is not used anywhere, but maybe it's intrusive for distributions.
> 
> Cc: Mathieu Trudel-Lapierre <[email protected]>
> Cc: Dragan Stancevic <[email protected]>
> Cc: Louis Bouchard <[email protected]>
> Cc: Ritesh Raj Sarraf <[email protected]>
> Cc: Benjamin Marzinski <[email protected]>
> Cc: Hannes Reinecke <[email protected]>
> Cc: Christophe Varoqui <[email protected]>
> Cc: device-mapper development <[email protected]>
> Signed-off-by: Xose Vazquez Perez <[email protected]>
> ---
>  Makefile.inc | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/Makefile.inc b/Makefile.inc
> index 01d743c..b7077fc 100644
> --- a/Makefile.inc
> +++ b/Makefile.inc
> @@ -60,10 +60,9 @@ RM          = rm -f
>  LN          = ln -sf
>  INSTALL_PROGRAM = install
>  
> -OPTFLAGS     = -Wunused -Wstrict-prototypes -O2 -g -pipe -Wformat-security 
> -Wall \
> -             -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector 
> --param=ssp-buffer-size=4
> -
> -CFLAGS            = $(OPTFLAGS) -fPIC -DLIB_STRING=\"${LIB}\" 
> -DRUN_DIR=\"${RUN}\"
> +CFLAGS      = -Wunused -Wstrict-prototypes -O2 -g -pipe -Wformat-security 
> -Wall \
> +             -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector 
> --param=ssp-buffer-size=4 \
> +             -fPIC -DLIB_STRING=\"${LIB}\" -DRUN_DIR=\"${RUN}\"
>  SHARED_FLAGS = -shared
>  
>  %.o: %.c
> 
Nope, doesn't work for us.
Our buildsystem is using a distinct set of flags, which we need to use
for the build process.
At the same time we have no idea if there are other flags (like includes
etc) which are required by the build itself.

Please revert, this breaks our build.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Teamlead Storage & Networking
[email protected]                                   +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)

--
dm-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/dm-devel

Reply via email to