On Mon, Oct 10 2016 at 12:48pm -0400, Heinz Mauelshagen <[email protected]> wrote:
> In case legs of a "mirror" target fail, any read will cause a new, > operational default leg to be selected and the read be resubmitted > to it. If that new default leg fails the read too, no other still > accessible legs are used to resubmit the read again thus failing > the io. > > Fix by allowing the read to get resubmitted until there's no > operational legs any more. > > Resolves: rhbz1383444 > > Signed-off-by: Heinz Mauelshagen <[email protected]> Nothing seems to be checking bio_record->details.bi_bdev anymore. (The one you've removed really seems like a complete hack to begin with) Shouldn't this patch go further by removing the other 2 places that set bio_record->details.bi_bdev = NULL; ? > --- > drivers/md/dm-raid1.c | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/drivers/md/dm-raid1.c b/drivers/md/dm-raid1.c > index 7a6254d..dd31019 100644 > --- a/drivers/md/dm-raid1.c > +++ b/drivers/md/dm-raid1.c > @@ -1266,16 +1266,6 @@ static int mirror_end_io(struct dm_target *ti, struct > bio *bio, int error) > goto out; > > if (unlikely(error)) { > - if (!bio_record->details.bi_bdev) { > - /* > - * There wasn't enough memory to record necessary > - * information for a retry or there was no other > - * mirror in-sync. > - */ > - DMERR_LIMIT("Mirror read failed."); > - return -EIO; > - } > - > m = bio_record->m; > > DMERR("Mirror read failed from %s. Trying alternative device.", > @@ -1291,7 +1281,6 @@ static int mirror_end_io(struct dm_target *ti, struct > bio *bio, int error) > bd = &bio_record->details; > > dm_bio_restore(bd, bio); > - bio_record->details.bi_bdev = NULL; > bio->bi_error = 0; > > queue_bio(ms, bio, rw); > -- > 2.7.4 > -- dm-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/dm-devel
