That's why we included a copy of the required valgrind header. Does this solution eleviate your complain ?
On Sun, Oct 16, 2016 at 6:59 PM, Hannes Reinecke <[email protected]> wrote: > On 10/16/2016 12:26 PM, Xose Vazquez Perez wrote: > >> On 10/08/2016 10:22 PM, Xose Vazquez Perez wrote: >> >> Cc: Bart Van Assche <[email protected]> >>> Cc: Christophe Varoqui <[email protected]> >>> Cc: device-mapper development <[email protected]> >>> Signed-off-by: Xose Vazquez Perez <[email protected]> >>> --- >>> libmultipath/debug.c | 2 +- >>> multipathd/main.c | 2 +- >>> 2 files changed, 2 insertions(+), 2 deletions(-) >>> >> >> This patch is missing. >> Thank you. >> >> >> diff --git a/libmultipath/debug.c b/libmultipath/debug.c >>> index 295136c..fbe171a 100644 >>> --- a/libmultipath/debug.c >>> +++ b/libmultipath/debug.c >>> @@ -8,7 +8,7 @@ >>> #include "log_pthread.h" >>> #include <sys/types.h> >>> #include <time.h> >>> -#include <../third-party/valgrind/drd.h> >>> +#include "../third-party/valgrind/drd.h" >>> #include "vector.h" >>> #include "config.h" >>> >>> diff --git a/multipathd/main.c b/multipathd/main.c >>> index cdfafe8..0998085 100644 >>> --- a/multipathd/main.c >>> +++ b/multipathd/main.c >>> @@ -23,7 +23,6 @@ >>> #endif >>> #include <semaphore.h> >>> #include <time.h> >>> -#include <valgrind/drd.h> >>> >>> /* >>> * libmultipath >>> @@ -85,6 +84,7 @@ int uxsock_timeout; >>> #include "lock.h" >>> #include "waiter.h" >>> #include "wwids.h" >>> +#include "../third-party/valgrind/drd.h" >>> >>> #define FILE_NAME_SIZE 256 >>> #define CMDSIZE 160 >>> >>> >> Please don't. > We're trying to keep dependencies to each package as small as possible. > And requiring valgrind by default is not going to help here. > Please make this a compile-time option. > > Cheers, > > Hannes > -- > Dr. Hannes Reinecke zSeries & Storage > [email protected] +49 911 74053 688 > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg > GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) > > > -- > dm-devel mailing list > [email protected] > https://www.redhat.com/mailman/listinfo/dm-devel >
-- dm-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/dm-devel
