On 04/26/2017 08:37 PM, Bart Van Assche wrote: > blk_mq_register_dev() can fail. Hence check the return value of > that function. > > Signed-off-by: Bart Van Assche <[email protected]> > Cc: Hannes Reinecke <[email protected]> > Cc: Christoph Hellwig <[email protected]> > --- > drivers/md/dm-rq.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/md/dm-rq.c b/drivers/md/dm-rq.c > index ba5694be55a4..3ff7280f5dc5 100644 > --- a/drivers/md/dm-rq.c > +++ b/drivers/md/dm-rq.c > @@ -813,10 +813,14 @@ int dm_mq_init_request_queue(struct mapped_device *md, > struct dm_table *t) > dm_init_md_queue(md); > > /* backfill 'mq' sysfs registration normally done in blk_register_queue > */ > - blk_mq_register_dev(disk_to_dev(md->disk), q); > + err = blk_mq_register_dev(disk_to_dev(md->disk), q); > + if (err) > + goto free_queue; > > return 0; > > +free_queue: > + blk_cleanup_queue(q); > out_tag_set: > blk_mq_free_tag_set(md->tag_set); > out_kfree_tag_set: > Reviewed-by: Hannes Reinecke <[email protected]>
Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking [email protected] +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- dm-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/dm-devel
