ACK, but I'm fine with Bart's patch as well. -Ben
On Fri, Jul 14, 2017 at 01:32:06PM +0200, Martin Wilck wrote: > If the first WWID_LEN bytes of the uuid_attribute do not contain > a 0 byte, pp->wwid may end up not properly terminated. Fix it. > > Signed-off-by: Martin Wilck <[email protected]> > --- > libmultipath/discovery.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libmultipath/discovery.c b/libmultipath/discovery.c > index 663c8eaa..9951af84 100644 > --- a/libmultipath/discovery.c > +++ b/libmultipath/discovery.c > @@ -1615,6 +1615,7 @@ get_udev_uid(struct path * pp, char *uid_attribute, > struct udev_device *udev) > len = strlen(value); > } > strncpy(pp->wwid, value, len); > + pp->wwid[WWID_SIZE - 1] = '\0'; > } else { > condlog(3, "%s: no %s attribute", pp->dev, > uid_attribute); > -- > 2.13.2 -- dm-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/dm-devel
