From: Goldwyn Rodrigues <[email protected]> One can crash dm-flakey by specifying more number of feature arguments than the number of features supplied. Checking for null in arg_name avoids this.
dmsetup create flakey-test --table "0 66076080 flakey /dev/sdb9 0 0 180 2 \ drop_writes" Signed-off-by: Goldwyn Rodrigues <[email protected]> --- drivers/md/dm-flakey.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/md/dm-flakey.c b/drivers/md/dm-flakey.c index e18c29672a88..995b69e98f9f 100644 --- a/drivers/md/dm-flakey.c +++ b/drivers/md/dm-flakey.c @@ -70,6 +70,11 @@ static int parse_features(struct dm_arg_set *as, struct flakey_c *fc, arg_name = dm_shift_arg(as); argc--; + if (!arg_name) { + ti->error = "Insufficient feature arguments"; + return -EINVAL; + } + /* * drop_writes */ -- 2.14.2 -- dm-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/dm-devel
