On Wed, 2018-02-28 at 17:47 -0600, Benjamin Marzinski wrote:
> 
> I have one nit here. print.h now relies on dm-generic.h, since it
> uses
> dm_multipath_to_gen() in its defines.  So shouldn't it simply include
> dm-generic.h, which would allow configure.c, main.c, and
> cli_handlers.c
> to not include dm-generic.h, since they only need it because they
> include print.h?

Sure, I can do that. 

This is a basic style question - should .h files (a) contain #includes
for all other header files they depend on, or should (b) the .c code
be required to #include everything in correct order? AFAICS we don't
have a policy about that in multipath-tools, it's sometimes this way
and sometimes the other way. Personally I'm slightly inclined towards
(b) because it makes the dependencies of .c files more explicit, but I
don't care much. (a) makes the life of the programmer a bit easier.

Regards,
Martin

-- 
Dr. Martin Wilck <mwi...@suse.com>, Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imend├Ârffer, Jane Smithard, Graham Norton
HRB 21284 (AG N├╝rnberg)

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

Reply via email to