On Sat, 14 Apr 2018 00:00:07 +0200
Martin Wilck <[email protected]> wrote:

> Use DM_MULTIPATH_DEVICE_PATH="2" to indicate that this might be a
> valid path, but we aren't certain. This happens with find_multipaths
> "smart", when the first path to a device (or a single-path
> device) is encountered, and the device is neither blacklisted,
> nor marked failed, nor whitelisted in the wwids file.
> 
> Reviewed-by: Benjamin Marzinski <[email protected]>
> Signed-off-by: Martin Wilck <[email protected]>
> ---
>  multipath/main.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/multipath/main.c b/multipath/main.c
> index 942caf4c..f62e18a9 100644
> --- a/multipath/main.c
> +++ b/multipath/main.c
> @@ -353,7 +353,7 @@ out:
>  static int print_cmd_valid(int k, const vector pathvec,
>                          struct config *conf)
>  {
> -     static const int vals[] = { 1, 0 };
> +     static const int vals[] = { 1, 0, 2 };
>  
>       if (k < 0 || k >= sizeof(vals))
>               return 1;
> @@ -504,6 +504,9 @@ configure (struct config *conf, enum mpath_cmds
> cmd,
>                * the refwwid, then the path is valid */
>               if (VECTOR_SIZE(curmp) != 0 || VECTOR_SIZE(pathvec)
> > 1) r = 0;
> +             else
> +                     /* Use r=2 as an indication for "maybe" */
> +                     r = 2;
>               goto print_valid;
>       }
>  

A very unusual array mapping ... Maybe it should be cleaned up?

Other than that:

Reviewed-by: Hannes Reinecke <[email protected]>

Cheers,

Hannes

--
dm-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/dm-devel

Reply via email to