BTRFS is the only user of this helper, so move this helper into
BTRFS, and implement it via bio_for_each_segment_all(), since
bio->bi_vcnt may not equal to number of pages after multipage bvec
is enabled.

Cc: Dave Chinner <dchin...@redhat.com>
Cc: Kent Overstreet <kent.overstr...@gmail.com>
Cc: Mike Snitzer <snit...@redhat.com>
Cc: dm-devel@redhat.com
Cc: Alexander Viro <v...@zeniv.linux.org.uk>
Cc: linux-fsde...@vger.kernel.org
Cc: Shaohua Li <s...@kernel.org>
Cc: linux-r...@vger.kernel.org
Cc: linux-er...@lists.ozlabs.org
Cc: David Sterba <dste...@suse.com>
Cc: linux-bt...@vger.kernel.org
Cc: Darrick J. Wong <darrick.w...@oracle.com>
Cc: linux-...@vger.kernel.org
Cc: Gao Xiang <gaoxian...@huawei.com>
Cc: Christoph Hellwig <h...@lst.de>
Cc: Theodore Ts'o <ty...@mit.edu>
Cc: linux-e...@vger.kernel.org
Cc: Coly Li <col...@suse.de>
Cc: linux-bca...@vger.kernel.org
Cc: Boaz Harrosh <o...@electrozaur.com>
Cc: Bob Peterson <rpete...@redhat.com>
Cc: cluster-de...@redhat.com
Signed-off-by: Ming Lei <ming....@redhat.com>
---
 fs/btrfs/extent_io.c | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
index 5d5965297e7e..874bb9aeebdc 100644
--- a/fs/btrfs/extent_io.c
+++ b/fs/btrfs/extent_io.c
@@ -2348,6 +2348,18 @@ struct bio *btrfs_create_repair_bio(struct inode *inode, 
struct bio *failed_bio,
        return bio;
 }
 
+static unsigned btrfs_bio_pages_all(struct bio *bio)
+{
+       unsigned i;
+       struct bio_vec *bv;
+
+       WARN_ON_ONCE(bio_flagged(bio, BIO_CLONED));
+
+       bio_for_each_segment_all(bv, bio, i)
+               ;
+       return i;
+}
+
 /*
  * this is a generic handler for readpage errors (default
  * readpage_io_failed_hook). if other copies exist, read those and write back
@@ -2368,7 +2380,7 @@ static int bio_readpage_error(struct bio *failed_bio, u64 
phy_offset,
        int read_mode = 0;
        blk_status_t status;
        int ret;
-       unsigned failed_bio_pages = bio_pages_all(failed_bio);
+       unsigned failed_bio_pages = btrfs_bio_pages_all(failed_bio);
 
        BUG_ON(bio_op(failed_bio) == REQ_OP_WRITE);
 
-- 
2.9.5

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

Reply via email to